fix(notifications): make close handler robust against edge cases#3309
Merged
Conversation
chrmod
approved these changes
May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardens the notification iframe close path so the popup (most visibly the 30-day review notification) cannot get stuck on screen. Two edge cases could leave the wrapper in the DOM after the user clicked close: (1) after an extension update/reload, the first call in the close handler —
chrome.runtime.sendMessage(CLEAR_ACTION)— throws synchronously withExtension context invalidated, aborting the rest of the cleanup; (2) the wrapper was only removed inside atransitionendlistener, which never fires underprefers-reduced-motion, hidden tabs, or accessibility tooling that disables CSS transitions.This PR wraps the
CLEAR_ACTIONbroadcast intry/catchand replaces thetransitionendlistener with asetTimeoutslightly longer than the 0.2s CSS transition, so cleanup always runs. Drive-by:awaitchrome.storage.local.setin the YouTube notification'sdontAskhandler so the value is persisted before the page closes.