Skip to content

Install chrome in codespaces via Dockerfile rather than use node-chromium package #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
manuelpuyol merged 3 commits into from
May 17, 2022
Merged

Install chrome in codespaces via Dockerfile rather than use node-chromium package #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ae19a76
install chrome in docker container
theinterned May 17, 2022
20ae5e7
unistall node-chromium
theinterned May 17, 2022
ec544c0
use system chrome
theinterned May 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .devcontainer/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,7 @@ FROM mcr.microsoft.com/vscode/devcontainers/javascript-node:0-${VARIANT}

# [Optional] Uncomment if you want to install more global node modules
# RUN su node -c "npm install -g <your-package-list-here>"

RUN wget -q -O - https://dl-ssl.google.com/linux/linux_signing_key.pub | apt-key add - \
&& echo "deb http://dl.google.com/linux/chrome/deb/ stable main" >> /etc/apt/sources.list.d/google.list
RUN apt-get update && apt-get -y install google-chrome-stable
3 changes: 0 additions & 3 deletions karma.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
/* eslint-disable filenames/match-regex */

// eslint-disable-next-line import/no-commonjs, no-undef, @typescript-eslint/no-var-requires
process.env.CHROME_BIN = require('chromium').path

function completer(request, response, next) {
if (request.method === 'GET' && request.url.startsWith('/search?q=hub')) {
response.writeHead(200)
Expand Down
Loading