This repository was archived by the owner on May 1, 2025. It is now read-only.
feat: support github enterprise api#142
Merged
zkoppert merged 2 commits intogithub:mainfrom Nov 4, 2024
Merged
Conversation
jmeridth
previously approved these changes
Nov 1, 2024
failing CI. Just saw it. Code looks good otherwise.
Member
|
RE: test failure. Test coverage is too low. If @jmeridth you feel like the added code has decent coverage for what was changed we can bypass this check. I'll open a new pr to add some tests. Looks like one file has 0% coverage. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Proposed Changes
This Pull request is based on the already merged github-community-projects/evergreen#256 to give support to GitHub Enterprise login using a GitHub App also created on GitHub Enterprise
.coveragercto ignore the python test files, because of that the coverage went below the limit of 60% and still need to check if there is the possibility to add tests for theopen_contrib_pr.pycodeCode coverage
Readiness Checklist
Author/Contributor
make lintand fix any issues that you have introducedmake testand ensure you have test coverage for the lines you are introducing@jeffrey-luszczReviewer
bug,documentation,enhancement,infrastructure,maintenanceorbreaking