Add test for domains with underscores and fix roundtrip behavior#292
Merged
kevinbackhouse merged 1 commit intogithub:masterfrom Jan 23, 2023
Merged
Conversation
kevinbackhouse
changed the title
stevenlaidlaw
approved these changes
Nov 2, 2022
anticomputer
approved these changes
Jan 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a test for the underscore logic in
check_domainin the autolink extension.I had to make a minor change to the code to get the "roundtrip" test to pass. The roundtrip test checks that converting to commonmark first and then to html gives the same result as converting directly to html. The first step converts the underscore to
\_which gets handled differently by the logic incheck_domain. Adding some code to skip the\character fixes it.