Expose CMARK_NODE_FOOTNOTE_DEFINITION literal value.#336
Merged
anticomputer merged 1 commit intogithub:masterfrom Jul 20, 2023
Merged
Expose CMARK_NODE_FOOTNOTE_DEFINITION literal value.#336anticomputer merged 1 commit intogithub:masterfrom
anticomputer merged 1 commit intogithub:masterfrom
Conversation
ioquatix
commented
Jun 19, 2023
ioquatix
force-pushed
the
expose-footnote-def-literal
branch
2 times, most recently
from
1a4b0b9 to
ab19806
Compare
In addition, fix a bug where the length of the literal value was calculated AFTER the actual literal string (null terminated) was allocated.
ioquatix
force-pushed
the
expose-footnote-def-literal
branch
from
ab19806 to
85d2eb9
Compare
Author
|
Sorry, there a glitch in the matrix, I've fixed the commit. |
ioquatix
changed the title
kevinbackhouse
approved these changes
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In addition, fix a bug where the length of the literal value was calculated AFTER the actual literal string (null terminated) was allocated.
Before this fix:
After this fix: