Replace the pool when reopening.#182
Closed
mhamza15 wants to merge 10 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR backports changes that replace the connection pool when reopening after closure. The primary goal is to ensure that pools are properly reset to a clean state when reopened, preventing potential issues with stale connections or corrupted pool state.
- Stores pool configuration and stats exporter references to enable pool recreation
- Replaces the ConnPool instance with a new one during the Close() operation
- Refactors stats registration to use a separate StatsExporter that can be reassigned to new pool instances
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go/vt/vttablet/tabletserver/connpool/pool.go | Stores config and statsExporter, recreates ConnPool on close |
| go/vt/dbconnpool/connection_pool.go | Similar changes to store config/statsExporter and recreate pool on close |
| go/pools/smartconnpool/pool_test.go | Simplifies test assertions for pool closing behavior |
| go/pools/smartconnpool/pool.go | Adds pool state management and refactors stats registration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Signed-off-by: Arthur Schreiber <arthurschreiber@github.com>
Signed-off-by: Arthur Schreiber <arthurschreiber@github.com>
Signed-off-by: Mohamed Hamza <mhamza15@github.com>
When closing the pool, there is a race condition between the closing of the `close` channel in `CloseWithContext`, and the `maybeStarving` worker closing it. We'll remove the close in `CloseWithContext` and allow the worker to close it on its next run. Signed-off-by: Mohamed Hamza <mhamza15@github.com>
Signed-off-by: Mohamed Hamza <mhamza15@github.com>
closing and normal operations Signed-off-by: Mohamed Hamza <mhamza15@github.com>
Signed-off-by: Mohamed Hamza <mhamza15@github.com>
Signed-off-by: Mohamed Hamza <mhamza15@github.com>
Signed-off-by: Mohamed Hamza <mhamza15@github.com>
f5f012e to
bc91d02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a backport of vitessio#18530
Related Issue(s)
Checklist
Deployment Notes