Skip to content

Gitlens crashes extension host when clicking on submodule commit change file in treeview #1803

@ulugbekna

Description

@ulugbekna
  • GitLens Version: 11.7.0
  • Git Version: 2.32.0
  • VSCode Version:
1.64.0
5554b12acf27056905806867f251c859323ff7e9
x64
  • OS Version: macOS Big Sur 11.6 (20G165)

Hi, when I click on a file that represents the update of a commit of a git submodule, the extension host terminates because of an exception thrown by gitlens

  ERR [Extension Host] (node:13650) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
(Use `Electron --trace-deprecation ...` to show where the warning was created)
workbench.desktop.main.js:75 [Extension Host] (node:13650) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.(Use `Electron --trace-deprecation ...` to show where the warning was created) (at writeOut (internal/process/warning.js:43:3))
I @ workbench.desktop.main.js:75
workbench.desktop.main.js:3036 Extension host (LocalProcess) terminated unexpectedly. Code: 7, Signal: null
_onExtensionHostCrashed @ workbench.desktop.main.js:3036
workbench.desktop.main.js:578   ERR Extension host (LocalProcess) terminated unexpectedly. The following extensions were running: vscode.microsoft-authentication, vscode.debug-auto-launch, vscode.git-base, GitHub.vscode-pull-request-github, vscodevim.vim, ms-vscode-remote.remote-containers, ocamllabs.ocaml-platform, vscode.github-authentication, vscode.git, vscode.github, vscode.emmet, vscode.merge-conflict, eamodio.gitlens, ms-vscode-remote.remote-wsl
workbench.desktop.main.js:788 Extension host terminated unexpectedly.
onDidChangeNotification @ workbench.desktop.main.js:788
workbench.desktop.main.js:578   ERR Error: Unable to read file 'gitlens://2cb1a2d/Users/ulugbekna/code/ocaml-lsp/ocaml-lsp-server/vendor/merlin?{"path":"/Users/ulugbekna/code/ocaml-lsp/ocaml-lsp-server/vendor/merlin","ref":"2cb1a2d57f7ff5cff6a87933c7513f7561e12efd","repoPath":"/Users/ulugbekna/code/ocaml-lsp"}' (Canceled: Canceled)
    at m.doReadFileStream (workbench.desktop.main.js:578)
    at async u.doRead (workbench.desktop.main.js:2385)
    at async u.readStream (workbench.desktop.main.js:2385)
    at async sn.resolveFromFile (workbench.desktop.main.js:2374)
    at async l.doResolve (workbench.desktop.main.js:2385)
    at async za.doResolveAsText (workbench.desktop.main.js:1739)
    at async Promise.all (index 0)
    at async Jr.createModel (workbench.desktop.main.js:1530)
    at async Jr.resolve (workbench.desktop.main.js:1530)
    at async cl.setInput (workbench.desktop.main.js:2351)
    at async i.doSetInput (workbench.desktop.main.js:2351)
    at async i.doOpenEditor (workbench.desktop.main.js:2351)
    at async i.openEditor (workbench.desktop.main.js:2351)
    at async workbench.desktop.main.js:2551
    at async workbench.desktop.main.js:2351
workbench.desktop.main.js:788 Unable to open 'merlin (2cb1a2d) ⟷ merlin (4d8d0e9)': Unable to read file 'gitlens://2cb1a2d/Users/ulugbekna/code/ocaml-lsp/ocaml-lsp-server/vendor/merlin?{"path":"/Users/ulugbekna/code/ocaml-lsp/ocaml-lsp-server/vendor/merlin","ref":"2cb1a2d57f7ff5cff6a87933c7513f7561e12efd","repoPath":"/Users/ulugbekna/code/ocaml-lsp"}' (Canceled: Canceled).
onDidChangeNotification @ workbench.desktop.main.js:788
workbench.desktop.main.js:3038 Extension Host
workbench.desktop.main.js:3038 /Users/ulugbekna/.vscode-insiders/extensions/ocamllabs.ocaml-platform-1.8.4/dist/vscode_ocaml_platform.bc.js:19534      throw err;      ^TypeError: f.trim is not a function    at new RunError (/Users/ulugbekna/.vscode-insiders/extensions/eamodio.gitlens-11.7.0/dist/webpack:/gitlens/src/git/shell.ts:152:19)    at /Users/ulugbekna/.vscode-insiders/extensions/eamodio.gitlens-11.7.0/dist/webpack:/gitlens/src/git/shell.ts:190:6    at ChildProcess.exithandler (child_process.js:324:5)    at ChildProcess.emit (events.js:315:20)    at maybeClose (internal/child_process.js:1048:16)    at Socket.<anonymous> (internal/child_process.js:439:11)    at Socket.emit (events.js:315:20)    at Pipe.<anonymous> (net.js:673:12)
workbench.desktop.main.js:578   ERR command '_vscode_delegate_cmd_kzcrhak0' not found: Error: command '_vscode_delegate_cmd_kzcrhak0' not found
    at b._tryExecuteCommand (vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1489:3364)
    at vscode-file://vscode-app/Applications/Visual%20Studio%20Code%20-%20Insiders.app/Contents/Resources/app/out/vs/workbench/workbench.desktop.main.js:1489:3245
DevTools failed to load source map: Could not load content for https://ticino.blob.core.windows.net/sourcemaps/5554b12acf27056905806867f251c859323ff7e9/core/vs/workbench/workbench.desktop.main.js.map: Load canceled due to load timeout

Reproduce

A way to reproduce is gh repo clone ocaml/ocaml-lsp && gh pr checkout 608
then click on “merlin” in the source control, see the screenshot

image

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-verificationRequest for verificationpending-releaseResolved but not yet released to the stable edition

    Type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions