This repository was archived by the owner on May 30, 2024. It is now read-only.
Add environment lock #116
Merged
Add environment lock #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
September 24, 2021 21:01
noahingh
commented
Sep 25, 2021
Comment on lines
+113
to
+119
| if locked, err := r.i.HasLockOfRepoForEnv(ctx, re, p.Env); locked { | ||
| r.log.Info("The env is locked.", zap.String("env", p.Env)) | ||
| gb.ErrorResponse(c, http.StatusUnprocessableEntity, "The env is locked. You should unlock the env before deploying.") | ||
| return | ||
| } else if err != nil { | ||
| r.log.Error("It has failed to check the lock.", zap.Error(err)) | ||
| gb.ErrorResponse(c, http.StatusInternalServerError, "It has failed to check the lock.") |
Comment on lines
+147
to
+149
| repov1.GET("/:id/locks", rm.RepoReadPerm(), r.ListLocks) | ||
| repov1.POST("/:id/locks", rm.RepoWritePerm(), r.CreateLock) | ||
| repov1.DELETE("/:id/locks/:lockID", rm.RepoWritePerm(), r.DeleteLock) |
Member
Author
There was a problem hiding this comment.
Add API for the locking system.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Lock tab to lock (or unlock) environment. It provides a fine-grained locking system.
Example