Output underlying load error when wrapping#284
Conversation
|
This looks great, thank you! I'm a bit suspicious of the Travis change; no other Ruby project I run has required a config change like that recently. What was the original error #283 was fixing? |
|
I think you're right to be suspicious, but I do think it (only partially -- see below) fixes the problem (without it I couldn't get travis to build even once) Firstly note that it seems to have been a sporadic problem on master (some builds failed, some succeeded). The failure that I think we're fixing here is: e.g. https://travis-ci.org/jch/html-pipeline/jobs/265274259#L321 This removes the |
|
Could you merge |
4516d3f to
b18a2a5
Compare
|
All done -- good to go! |
|
Fantastic, thanks! |
|
Out as 2.7.1. |
Fixes #282. Depends on #283 for travis.
In the end it seemed cleaner (and safer) to create a tested utility-method for catching the LoadError and then reissuing with added information.
Currently in separate commits for ease of reading, but can squash /rebase if desired.