feat(Gitlab): add storage size to spec gitlab-data#530
Open
jrab66 wants to merge 1 commit intoglasskube:mainfrom
Open
feat(Gitlab): add storage size to spec gitlab-data#530jrab66 wants to merge 1 commit intoglasskube:mainfrom
jrab66 wants to merge 1 commit intoglasskube:mainfrom
Conversation
Member
|
Hi @jrab66, thanks for your contribution! 🚀 Your code changes look fine, they should not lead to any errors that did not happen previously. I haven't personally tried the As a workaround, you can use |
Author
|
@kosmoz not sure why still complains but I did the following: follow your steps and install helm chart with apply
but |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initial changes trying to add changes for #529
I did try to build and follow the contributing guide
I did manage to build succesfully I think.
I installing the operator to minikube with:
I override to latest or the tag that is pushed to minikube
values-reference:
install
But seems operator fails to run:
Prior to change image was not complaining over
veleroresources?