fix(ci): persist credentials in dependabot-tidy so push succeeds#5685
Merged
moul merged 2 commits intoMay 19, 2026
Conversation
The `tidy_go_mods` job runs `make tidy`, commits the result, and pushes it back to the dependabot PR's branch. After gnolang#5452 added `persist-credentials: false` to the checkout step, the push step fails with "could not read Username for 'https://github.com'" because the `git-auto-commit-action` does a plain `git push` and relies on credentials configured in the local repo by `actions/checkout`. The job already requests `contents: write`; persisting credentials is the intended behavior here.
Collaborator
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):🟢 Maintainers must be able to edit this pull request (more info) ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
The checkout step intentionally persists credentials so the git-auto-commit-action below can push back to the dependabot PR. Mark the artipacked finding as ignored so stricter zizmor personas don't report it.
thehowl
added a commit
that referenced
this pull request
May 18, 2026
Member
Author
|
verified on #5292 (merged in this pr, workflow works again) |
moul
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
tidy_go_modsjob in.github/workflows/meta-dependabot-tidy.ymlrunsmake tidyon dependabot PRs that touchgo.mod/go.sum, then usesstefanzweifel/git-auto-commit-actionto commit and push the result back to the PR branch.Since #5452 added
persist-credentials: falseto theactions/checkoutstep, every run of this job that produces changes fails at the push step:The auto-commit action does a plain
git pushand relies on the credentials persisted into.git/configbyactions/checkout. Withpersist-credentials: false, no credentials are available and the push fails with exit code 128. TheGITHUB_TOKENenv var passed to the step is not consumed by recent versions of the action for HTTPS auth.Example failure: https://github.com/gnolang/gno/actions/runs/25812055587/job/76559999785 (PR #5292).
This fix flips
persist-credentialsback totrue(the default) and adds a comment explaining why. The job already requestscontents: write, so persisting the token is the intended behavior here.zizmor passes on the default persona (the one CI runs). The auditor persona flags this as
artipacked(low confidence), but that persona is not enabled in CI.Test plan
go.mod/go.sumand confirm thetidy_go_modscheck passes.