Skip to content

FastPathAlloc: Skip if below clang 18.1.x#304

Merged
hmelder merged 2 commits into
masterfrom
strict-ver-check
Oct 22, 2024
Merged

FastPathAlloc: Skip if below clang 18.1.x#304
hmelder merged 2 commits into
masterfrom
strict-ver-check

Conversation

@hmelder

@hmelder hmelder commented Oct 21, 2024

Copy link
Copy Markdown
Member

Fixes #301

We probably need to disable the arm64 android emulation as Google completely broke it.

@triplef

triplef commented Oct 22, 2024

Copy link
Copy Markdown
Member

We probably need to disable the arm64 android emulation as Google completely broke it.

How so? From what I can tell only the FastPathAlloc test is failing in the latest builds, which should be fixed with your updated Clang version check, right?

@hmelder

hmelder commented Oct 22, 2024

Copy link
Copy Markdown
Member Author

From what I can tell only the FastPathAlloc test is failing in the latest builds, which should be fixed with your updated Clang version check, right?

Google broke ARM64 emulation on x86_64 hosts a while a go. One workaround was to overwrite the qemu machine type, but I guess they changed this with the newer emulator version. Apart from this, it really bottlenecked the CI, because it was just terrible slow. The real solution is to virtualise it on an AArch64 platform.

@triplef

triplef commented Oct 22, 2024

Copy link
Copy Markdown
Member

I see, but the latest builds seem to run fine (minus the FastPathAlloc issue)?
E.g. https://github.com/gnustep/libobjc2/actions/runs/11118537658/job/30892281978

@hmelder

hmelder commented Oct 22, 2024

Copy link
Copy Markdown
Member Author

I see, but the latest builds seem to run fine?

Take a look at https://github.com/gnustep/libobjc2/actions/runs/11445118340/job/31841516643: MU2 emulator does not support arm64 CPU architecture[command]/usr/local/lib/android/sdk/platform-tools/adb -s emulator-5554 shell getprop sys.boot_completed

@hmelder hmelder requested a review from davidchisnall October 22, 2024 12:59

@davidchisnall davidchisnall left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hmelder hmelder merged commit feaf007 into master Oct 22, 2024
@hmelder hmelder deleted the strict-ver-check branch October 22, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

FastPathAlloc tests failing on Android NDK r27

3 participants