docs: update purego comparison with verified source claims#29
Merged
Conversation
- ARM64 HFA: 'top-level only' → 'partial recursive (bug in nested path)' verified from purego/struct_arm64.go:256 (isHFA passes first.Type instead of Field(i).Type) - Platforms: '9+ architectures' → '8 GOARCH / 20+ OS×ARCH' verified from purego/zcallback_*.s (8 files: 386, amd64, arm, arm64, loong64, ppc64le, riscv64, s390x) - Per-call: 'sync.Pool per call' → 'reflect + sync.Pool per call' verified from purego/func.go (reflect.MakeFunc closure + thePool) - Struct pass/return: 'Full' → 'Partial (no Windows structs)' purego issue #237 still open - Callback float returns: clarified as 'Not supported (panic)' verified from purego/syscall_sysv.go:95 - purego overhead: '~100 ns' → 'Not published' (no official benchmarks exist) - Add JupiterRider/ffi to See also (purego binding for libffi, 203 stars)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update purego comparison claims with data verified directly from purego source code (
reference/purego/).Changes verified from source:
struct_arm64.go:256zcallback_*.sfilesfunc.goreflect.MakeFunc closuresyscall_sysv.go:95Test plan