Cleanup/UI code standards#743
Open
PartySensei wants to merge 3 commits into
Open
Conversation
- Wallet discovery and migration - Bitcoin Core directory and operation mode setup - Database configuration (local/remote) - Settings validation and persistence - WalletTypes enum refactoring (WLTTYPES -> WalletTypes) - Code quality improvements
- Remove dead code - Fix 81-char line limit - Fix code quality issues - Fix logic bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code quality pass on UI layer to farm out re-usable UI from DlgWalletMigration.py into qt defines.py, remove dead code, and fix coding standard violations.