[4.0] SCons: Fix BoolVariable import for SCons 4.8.0+#1526
[4.0] SCons: Fix BoolVariable import for SCons 4.8.0+#1526akien-mga wants to merge 1 commit intogodotengine:4.0from
Conversation
|
See discussion in #1518 (which this PR fixes) |
|
I intend to cherry-pick #1504, so a separate PR just for this change isn't necessary UPDATE: Er, well, I wasn't planning to cherry-pick to 4.0, so if we want this in 4.0 that probably will need it's own PR. We've kept the build system for 4.1, 4.2 and master in pretty close sync, but 4.0 is quite different at this point. |
e92d324 to
8e22ac2
Compare
Done! |
|
I suspect the CI builds are stuck because we didn't cherry-pick PR #1496 to 4.0. I just added the |
|
PR #1533 does the few cherry-picks we have for 4.0. Let's see if that manages to finish CI! |
|
Rebasing this on the latest |
See godotengine/godot#94410 and https://stackoverflow.com/questions/78746956/error-name-boolvariable-is-not-defined-when-using-scons-on-godot-with-c for details.
Not needed in
masteras this was already changed by #1504.Should be cherry-picked for 4.1 and 4.0, doesn't seem needed in 3.x/3.5.