fix(metal): configure stencil attachment in BeginRenderPass#101
Merged
Conversation
BeginRenderPass configured only the depth attachment, completely skipping rpDesc.stencilAttachment. On Apple Silicon TBDR GPUs with combined Depth32FloatStencil8 format, the stencil load action defaulted to MTLLoadActionDontCare, leaving stencil values undefined between frames and causing progressive rendering artifacts on Retina displays. Now configures stencilAttachment with texture, load/store actions, and clear value. Also adds explicit setClearDepth: call for depth attachment. Matches Rust wgpu-hal metal/command.rs:705-727 and aligns with the Vulkan and DX12 backends which already handle stencil correctly. Ref: gogpu/gg#171
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BeginRenderPass— only depth attachment was configured, stencil was completely skippedsetClearDepth:call for depth attachment (was relying on Metal's default)metal/command.rs:705-727and aligns with Vulkan/DX12 backends which already handle stencil correctlyProblem
On Apple Silicon TBDR GPUs with combined
Depth32FloatStencil8format, the missing stencil attachment leftMTLLoadActionDontCareas default. This caused undefined stencil values between frames and progressive rendering artifacts on macOS Retina displays.Ref: gogpu/gg#171
Test plan
go test ./...— 14 packages)golangci-lint run— 0 issues)go fmtclean