feat(core): comprehensive render/compute pass validation (v0.21.2)#105
Merged
feat(core): comprehensive render/compute pass validation (v0.21.2)#105
Conversation
Track pipeline bind group count at SetPipeline, validate index < count at SetBindGroup. Prevents vkCmdBindDescriptorSets crash on AMD/NVIDIA when bind group index exceeds pipeline layout set count.
Matching Rust wgpu-core validation pattern: - Binder: tracks assigned vs expected bind group layouts per slot - SetBindGroup: MAX_BIND_GROUPS hard cap, index bounds, layout tracking - SetPipeline: updates expected layouts, tracks pipeline state - Draw/DrawIndexed: validates pipeline set + bind group compatibility - Dispatch: validates pipeline set + bind group compatibility - 13 binder tests + 9 integration tests - Prevents AMD/NVIDIA crash (ui#52) at wgpu API level
- Dynamic offset alignment check (256 bytes) in SetBindGroup - Vertex buffer count validation in Draw/DrawIndexed - Index buffer set check in DrawIndexed/DrawIndexedIndirect - Extracted validateSetBindGroup helper (DRY render/compute) - 15 new tests, 0 regressions
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
14/17 Rust wgpu-core validation checks. Binder struct, SetBindGroup bounds, draw-time compatibility, dynamic offsets, vertex/index buffer. Fixes AMD/NVIDIA crash (ui#52).