Add support for stripped go binaries#426
Merged
Merged
Conversation
Member
|
Thank you very much for your contribution. However, could you first raise an issue and provide some additional information about the case? Also, please add some validation demos in this PR. Thank you very much. |
Contributor
Author
|
@cfc4n , I had created an issue with extra info. Thanks |
cfc4n
reviewed
Nov 25, 2023
Member
cfc4n
left a comment
cfc4n
left a comment
There was a problem hiding this comment.
I think this PR cannot support stripped Go binaries.
| allSymbs = append(allSymbs, goSymbs...) | ||
| } | ||
|
|
||
| goDynamicSymbs, _ := gc.goElf.DynamicSymbols() |
Member
There was a problem hiding this comment.
in stripped compiled files , there are also no symbols in the DynamicSymbols section.
Contributor
Author
cfc4n
added
help wanted
cfc4n
added a commit
that referenced
this pull request
Dec 1, 2023
see #426 for more detail. Signed-off-by: cfc4n <cfc4n.cs@gmail.com>
cfc4n
added a commit
that referenced
this pull request
Dec 1, 2023
see #426 for more detail. Signed-off-by: cfc4n <cfc4n.cs@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently ecapture fails for stripped go binaries.
Because in
findRetOffsets()method, only symbols fromsym table sectionare consider for searching ofGoTlsReadFunc symbol. Since in case of stripped go binaries nosym table sectionis present, ecapture fails to initialise.This PR adds dynamic symbols in search space to fix the issue.
fixes #428