add -race flags for `go test` and fix data race warning by ruitianzhong · Pull Request #499 · gojue/ecapture

ruitianzhong · 2024-03-02T03:54:02Z

When add -race to go test , several data race warnings are raised.

first one(data race for workerqueue in EventProcessor):

WARNING: DATA RACE
Read at 0x00c000098c30 by goroutine 7:
  ecapture/pkg/event_processor.(*EventProcessor).Close()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:118 +0xb04
  ecapture/pkg/event_processor.TestEventProcessor_Serve()
      /home/rtzhong/ecapture/pkg/event_processor/processor_test.go:77 +0xb29
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1689 +0x21e
  testing.(*T).Run.gowrap1()
      /usr/local/go/src/testing/testing.go:1742 +0x44

Previous write at 0x00c000098c30 by goroutine 9:
  runtime.mapdelete_faststr()
      /usr/local/go/src/runtime/map_faststr.go:301 +0x0
  ecapture/pkg/event_processor.(*EventProcessor).delWorkerByUUID()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:105 +0xed
  ecapture/pkg/event_processor.(*eventWorker).Close()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:152 +0x99
  ecapture/pkg/event_processor.(*eventWorker).Run()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:134 +0x1e4
  ecapture/pkg/event_processor.NewEventWorker.func1()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:58 +0x2e

Goroutine 7 (running) created at:
  testing.(*T).Run()
      /usr/local/go/src/testing/testing.go:1742 +0x825
  testing.runTests.func1()
      /usr/local/go/src/testing/testing.go:2161 +0x85
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1689 +0x21e
  testing.runTests()
      /usr/local/go/src/testing/testing.go:2159 +0x8be
  testing.(*M).Run()
      /usr/local/go/src/testing/testing.go:2027 +0xf17
  main.main()
      _testmain.go:47 +0x2bd

Goroutine 9 (finished) created at:
  ecapture/pkg/event_processor.NewEventWorker()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:57 +0x11c
  ecapture/pkg/event_processor.(*EventProcessor).dispatch()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:68 +0x86
  ecapture/pkg/event_processor.(*EventProcessor).Serve()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:57 +0x65
  ecapture/pkg/event_processor.TestEventProcessor_Serve.func1()
      /home/rtzhong/ecapture/pkg/event_processor/processor_test.go:46 +0x25

the second one (data race HttpRequest and HttpResponse but they are benign data race):

WARNING: DATA RACE
Write at 0x00c000078100 by goroutine 13:
  ecapture/pkg/event_processor.(*HTTPRequest).detect()
      /home/rtzhong/ecapture/pkg/event_processor/http_request.go:88 +0x1f2
  ecapture/pkg/event_processor.NewParser()
      /home/rtzhong/ecapture/pkg/event_processor/iparser.go:89 +0x22d
  ecapture/pkg/event_processor.(*eventWorker).parserEvents()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:117 +0xf1
  ecapture/pkg/event_processor.(*eventWorker).Display()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:86 +0x3e
  ecapture/pkg/event_processor.(*eventWorker).Close()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:150 +0x67
  ecapture/pkg/event_processor.(*eventWorker).Run()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:134 +0x1e4
  ecapture/pkg/event_processor.NewEventWorker.func1()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:58 +0x2e

Previous write at 0x00c000078100 by goroutine 9:
  ecapture/pkg/event_processor.(*HTTPRequest).detect()
      /home/rtzhong/ecapture/pkg/event_processor/http_request.go:88 +0x1f2
  ecapture/pkg/event_processor.NewParser()
      /home/rtzhong/ecapture/pkg/event_processor/iparser.go:89 +0x22d
  ecapture/pkg/event_processor.(*eventWorker).parserEvents()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:117 +0xf1
  ecapture/pkg/event_processor.(*eventWorker).Display()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:86 +0x3e
  ecapture/pkg/event_processor.(*eventWorker).Close()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:150 +0x67
  ecapture/pkg/event_processor.(*eventWorker).Run()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:134 +0x1e4
  ecapture/pkg/event_processor.NewEventWorker.func1()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:58 +0x2e

Goroutine 13 (running) created at:
  ecapture/pkg/event_processor.NewEventWorker()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:57 +0x11c
  ecapture/pkg/event_processor.(*EventProcessor).dispatch()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:68 +0x86
  ecapture/pkg/event_processor.(*EventProcessor).Serve()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:57 +0x65
  ecapture/pkg/event_processor.TestEventProcessor_Serve.func1()
      /home/rtzhong/ecapture/pkg/event_processor/processor_test.go:46 +0x25

Goroutine 9 (running) created at:
  ecapture/pkg/event_processor.NewEventWorker()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:57 +0x11c
  ecapture/pkg/event_processor.(*EventProcessor).dispatch()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:68 +0x86
  ecapture/pkg/event_processor.(*EventProcessor).Serve()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:57 +0x65
  ecapture/pkg/event_processor.TestEventProcessor_Serve.func1()
      /home/rtzhong/ecapture/pkg/event_processor/processor_test.go:46 +0x25
==================
==================
WARNING: DATA RACE
Write at 0x00c0000162c0 by goroutine 10:
  ecapture/pkg/event_processor.(*HTTPResponse).detect()
      /home/rtzhong/ecapture/pkg/event_processor/http_response.go:104 +0x1f8
  ecapture/pkg/event_processor.NewParser()
      /home/rtzhong/ecapture/pkg/event_processor/iparser.go:89 +0x22d
  ecapture/pkg/event_processor.(*eventWorker).parserEvents()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:117 +0xf1
  ecapture/pkg/event_processor.(*eventWorker).Display()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:86 +0x3e
  ecapture/pkg/event_processor.(*eventWorker).Close()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:150 +0x67
  ecapture/pkg/event_processor.(*eventWorker).Run()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:134 +0x1e4
  ecapture/pkg/event_processor.NewEventWorker.func1()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:58 +0x2e

Previous write at 0x00c0000162c0 by goroutine 12:
  ecapture/pkg/event_processor.(*HTTPResponse).detect()
      /home/rtzhong/ecapture/pkg/event_processor/http_response.go:104 +0x1f8
  ecapture/pkg/event_processor.NewParser()
      /home/rtzhong/ecapture/pkg/event_processor/iparser.go:89 +0x22d
  ecapture/pkg/event_processor.(*eventWorker).parserEvents()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:117 +0xf1
  ecapture/pkg/event_processor.(*eventWorker).Display()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:86 +0x3e
  ecapture/pkg/event_processor.(*eventWorker).Close()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:150 +0x67
  ecapture/pkg/event_processor.(*eventWorker).Run()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:134 +0x1e4
  ecapture/pkg/event_processor.NewEventWorker.func1()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:58 +0x2e

Goroutine 10 (running) created at:
  ecapture/pkg/event_processor.NewEventWorker()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:57 +0x11c
  ecapture/pkg/event_processor.(*EventProcessor).dispatch()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:68 +0x86
  ecapture/pkg/event_processor.(*EventProcessor).Serve()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:57 +0x65
  ecapture/pkg/event_processor.TestEventProcessor_Serve.func1()
      /home/rtzhong/ecapture/pkg/event_processor/processor_test.go:46 +0x25

Goroutine 12 (running) created at:
  ecapture/pkg/event_processor.NewEventWorker()
      /home/rtzhong/ecapture/pkg/event_processor/iworker.go:57 +0x11c
  ecapture/pkg/event_processor.(*EventProcessor).dispatch()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:68 +0x86
  ecapture/pkg/event_processor.(*EventProcessor).Serve()
      /home/rtzhong/ecapture/pkg/event_processor/processor.go:57 +0x65
  ecapture/pkg/event_processor.TestEventProcessor_Serve.func1()
      /home/rtzhong/ecapture/pkg/event_processor/processor_test.go:46 +0x25

Signed-off-by: ruitianzhong <ruitian-zhong@outlook.com>

cfc4n

LGTM, thanks.

add -race flags for go test and fix data race warning

d70e863

Signed-off-by: ruitianzhong <ruitian-zhong@outlook.com>

cfc4n approved these changes Mar 2, 2024

View reviewed changes

Comment thread pkg/event_processor/http_request.go

cfc4n merged commit b2aeb73 into gojue:master Mar 2, 2024

ruitianzhong deleted the race-check branch March 2, 2024 12:42

cfc4n added the enhancement New feature or request label Mar 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add -race flags for `go test` and fix data race warning#499

add -race flags for `go test` and fix data race warning#499
cfc4n merged 1 commit into
gojue:masterfrom
ruitianzhong:race-check

ruitianzhong commented Mar 2, 2024

Uh oh!

cfc4n left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ruitianzhong commented Mar 2, 2024

Uh oh!

cfc4n left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants