kern: Adjust the timing of key acquisition to distinguish between TLS#576
Merged
Conversation
… versions * The best way is to first determine the current SSL mode, whether it is server or client. Currently, * the ssl->server field is of bool type, and using the offsetof method is not very readable. * Therefore, the minimum value of the state is temporarily used instead. * The judgment mechanism for TLS 1.3 follows the same approach. Signed-off-by: CFC4N <cfc4n.cs@gmail.com>
Member
Author
|
你可以帮忙测试一下吗？使用非Android的boringssl类库，测试一下这个PR是否能正常捕获密钥。 分别以Server\Client两种模式，测试TLS 1.2、1.3的情况，谢谢。 Can you help test this? Using the non-Android boringssl library, check if this PR can properly capture the key. Test in both Server and Client modes for TLS 1.2 and 1.3 scenarios, thank you.
|
|
辛苦了，我这周来搭环境验证 |
|
验证情况如下： |
|
上述4种场景都验证了，都可以取到key了 All four scenarios have been verified and the key can be obtained. |
Member
Author
pcapng包里，可以正常看到解密后的明文文本吗？ In the pcapng file, can you normally see the plaintext text after decryption? |
|
pcap的包 4种情况也都验证通过 The pcap packets have successfully passed all four tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
最好的办法是先判断当前SSL的模式，是server还是client。 目前ssl->server 字段是bool类型，offsetof方法不太好读取，暂时使用state的最小值代替， 下面 TLS 1.3的判断机制也是这样。
The best way is to first determine the current SSL mode, whether it is server or client. Currently, the ssl->server field is of bool type, and using the offsetof method is not very readable. Therefore, the minimum value of the state is temporarily used instead. The judgment mechanism for TLS 1.3 follows the same approach.