Skip to content

fix(ecaptureq): adjust heartbeat frequency and trigger immediate ping#884

Merged
cfc4n merged 1 commit into
gojue:masterfrom
zenyanle:heatbeat-update
Dec 4, 2025
Merged

fix(ecaptureq): adjust heartbeat frequency and trigger immediate ping#884
cfc4n merged 1 commit into
gojue:masterfrom
zenyanle:heatbeat-update

Conversation

@zenyanle
Copy link
Copy Markdown
Member

@zenyanle zenyanle commented Dec 4, 2025

No description provided.

@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 4, 2025
@cfc4n cfc4n requested a review from Copilot December 4, 2025 04:34
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts the websocket client heartbeat mechanism by reducing the heartbeat interval from 60 seconds to 15 seconds and adding an immediate heartbeat ping when the client connection is established. This ensures faster detection of connection issues and provides quicker feedback on connectivity status.

Key Changes:

  • Reduced heartbeat timer interval from 60 seconds to 15 seconds
  • Added immediate heartbeat call when writePump starts to verify connection immediately

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Member

@cfc4n cfc4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM.

@dosubot dosubot Bot added the lgtm This PR has been approved by a maintainer label Dec 4, 2025
@cfc4n cfc4n merged commit 24ab575 into gojue:master Dec 4, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants