feat(gotls): support Go binaries built with -ldflags="-s -w"#907
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes gotls work with Go binaries compiled with
-ldflags="-s -w"by resolving function addresses and return offsets from Go’s own symbol table when the ELF symbol table is stripped.Fixes #848.
Background
Currently
gotlsrelies on existing ELF information to locate tls functions.The standard symbol table and debug info are stripped when Go binaries built with
-ldflags="-s -w". The existing logic (findRetOffsets) may fail to locate the needed function and return address. It will be fatal with"symbol not found".Changes
When parsing non-PIE Go binaries and the origin logic
findRetOffsetsdoes not work, it will try to lookup function withgoSymTaband maps the funtion entry from virtual address to file offset using the.textsection.This works even when the standard ELF symbol table is stripped, because Go's own symbol table(
gosym) is still available.Testing
go version go1.24.6 linux/amd646.8.0-90-genericgo build -ldflags="-s -w" -o gotls_example