Skip to content

Add AGENTS.md for AI coding agent guidance#969

Merged
cfc4n merged 1 commit into
masterfrom
docs/add-agents-md
Mar 29, 2026
Merged

Add AGENTS.md for AI coding agent guidance#969
cfc4n merged 1 commit into
masterfrom
docs/add-agents-md

Conversation

@cfc4n
Copy link
Copy Markdown
Member

@cfc4n cfc4n commented Mar 29, 2026

This pull request adds a comprehensive AGENTS.md documentation file, providing an architectural and operational guide for the eCapture project. The new document outlines the project structure, build and test procedures, conventions, and a checklist for adding new probes, making it easier for contributors (including AI agents) to understand and extend the codebase.

Documentation improvements:

  • Added AGENTS.md, a detailed guide covering the eCapture project architecture, directory structure, build system requirements, testing procedures, code conventions, and step-by-step instructions for adding new probes.

Open with Devin

Copilot AI review requested due to automatic review settings March 29, 2026 04:03
@dosubot dosubot Bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation labels Mar 29, 2026
Copy link
Copy Markdown
Contributor

@devin-ai-integration devin-ai-integration Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

@cfc4n cfc4n merged commit 9b1d746 into master Mar 29, 2026
2 checks passed
@cfc4n cfc4n deleted the docs/add-agents-md branch March 29, 2026 04:05
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new AGENTS.md contributor guide intended to help (AI and human) contributors understand eCapture’s architecture, build/test workflow, and conventions.

Changes:

  • Introduces AGENTS.md documenting project architecture and key directories.
  • Documents Linux-only build workflow (Make targets, tags, cross-compile/Android notes) and testing entry points.
  • Provides a checklist/conventions section for adding new probes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread AGENTS.md
- **`internal/errors/`** — Structured error types with error codes (e.g., `ErrCodeProbeStart = 202`).
- **`internal/output/`** — Writers (`file`, `pcap`, `keylog`, `tcp`, `websocket`) and encoders (`json`, `plain`, `protobuf`).
- **`cli/cmd/`** — One file per subcommand (`tls.go`, `bash.go`, `gotls.go`, etc.). Commands wire probe config flags and invoke the factory.
- **`pkg/event_processor/`** — HTTP/2 request/response parsing from captured TLS data.
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pkg/event_processor/ is described as only doing HTTP/2 parsing, but the directory also contains HTTP/1.x parsers (e.g., http_request.go, http_response.go). Please update this line to reflect that it handles both HTTP/1.x and HTTP/2 (or more generally HTTP parsing from captured TLS data).

Suggested change
- **`pkg/event_processor/`** — HTTP/2 request/response parsing from captured TLS data.
- **`pkg/event_processor/`** — HTTP request/response parsing (HTTP/1.x and HTTP/2) from captured TLS data.

Copilot uses AI. Check for mistakes.
Comment thread AGENTS.md
## Testing
```sh
# Unit tests (on Linux)
make test-race # go test -race -tags dynamic,ebpfassets ./...
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The make test-race description omits that the Makefile also writes a coverage profile (-coverprofile=coverage.out). Consider updating the comment so contributors know it generates coverage.out as well.

Suggested change
make test-race # go test -race -tags dynamic,ebpfassets ./...
make test-race # go test -race -coverprofile=coverage.out -tags dynamic,ebpfassets ./... (generates coverage.out)

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants