fix(core): handle EISDIR in robustRealpath on Windows

[sehoon38]

Summary

Handle EISDIR errors in robustRealpath to improve robustness on Windows. Added a corresponding test case to verify the fix.

Details

On Windows, fs.realpathSync can sometimes throw EISDIR instead of ENOENT for certain paths (e.g., when a path component is invalid but looks like a directory, or for certain reserved names). This PR ensures robustRealpath handles EISDIR similarly to ENOENT by attempting to resolve through parent directories.

Related Issues

Fixes #21975

How to Validate

Run unit tests:

npx vitest packages/core/src/utils/paths.test.ts

Pre-Merge Checklist

• Updated relevant documentation and README (if needed)
• Added/updated tests (if needed)
• Noted breaking changes (if any)
• Validated on required platforms/methods:
  • MacOS
    • npm run

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the robustRealpath utility function to improve its reliability on Windows systems. By explicitly accounting for EISDIR errors, which can occur under specific conditions with fs.realpathSync, the change ensures that path resolution remains consistent and robust, preventing unexpected failures when dealing with certain directory structures or reserved names.

Highlights

• Enhanced Error Handling: The robustRealpath function now explicitly handles EISDIR errors on Windows, treating them similarly to ENOENT errors to improve path resolution robustness.
• New Test Case: A dedicated test case was added to verify that robustRealpath correctly processes paths even when fs.realpathSync throws an EISDIR error.

Changelog

• packages/core/src/utils/paths.test.ts
  • Added a new test case to simulate EISDIR errors from fs.realpathSync and verify robustRealpath's behavior.
• packages/core/src/utils/paths.ts
  • Modified robustRealpath to include EISDIR in the error codes handled alongside ENOENT when fs.realpathSync fails.
  • Updated the error handling for lstatSync to also consider EISDIR as a recoverable error when resolving parent directories.

Activity

• The author confirmed that relevant documentation and README were updated.
• The author confirmed that new tests were added to cover the changes.
• The author validated the changes on MacOS using npm run.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue where fs.realpathSync can throw an EISDIR error on Windows for certain invalid paths. The change modifies robustRealpath to handle EISDIR in the same manner as ENOENT, which involves recursively resolving the parent path. This improves the function's robustness. A new test case has been added to validate this specific error handling scenario. The implementation is correct and well-tested.

[github-actions]

Size Change: +56 B (0%)

Total Size: 26.5 MB

ℹ️ View Unchanged

Filename	Size	Change
./bundle/gemini.js	26 MB	+56 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js	221 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js	227 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js	11.5 kB	0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js	132 B	0 B
./bundle/sandbox-macos-permissive-open.sb	890 B	0 B
./bundle/sandbox-macos-permissive-proxied.sb	1.31 kB	0 B
./bundle/sandbox-macos-restrictive-open.sb	3.36 kB	0 B
./bundle/sandbox-macos-restrictive-proxied.sb	3.56 kB	0 B
./bundle/sandbox-macos-strict-open.sb	4.82 kB	0 B
./bundle/sandbox-macos-strict-proxied.sb	5.02 kB	0 B

_{compressed-size-action}

[yunaseoul]

lgtm