Skip to content

fix(core): fix startup stats to use int values for timestamps and durations#22201

Merged
yunaseoul merged 1 commit intomainfrom
yunaseol/startup-stats
Mar 12, 2026
Merged

fix(core): fix startup stats to use int values for timestamps and durations#22201
yunaseoul merged 1 commit intomainfrom
yunaseol/startup-stats

Conversation

@yunaseoul
Copy link
Copy Markdown
Contributor

Summary

Ensures that startup stats timestamps and duration values are correctly formatted as integers in StartupProfiler.

Details

Applied Math.round() to duration_ms, start_time_usec, and end_time_usec before adding them to the telemetry startup phases. This fixes schema compliance issues related to telemetry logging where floating-point numbers were being emitted instead of integers. Added unit tests to verify the integer outputs.

Related Issues

Related to #21161
Related to https://github.com/google-gemini/maintainers-gemini-cli/issues/1513

How to Validate

  • Run the unit tests for telemetry: npm test -w @google/gemini-cli-core -- src/telemetry/startupProfiler.test.ts
  • Check the logged telemetry payload on startup and confirm the types are integers for phase timing.

Pre-Merge Checklist

  • Added/updated tests (if needed)

… durations

Round `duration_ms`, `start_time_usec`, and `end_time_usec` to the nearest
integer in `StartupProfiler` to ensure schema compliance and consistent
telemetry logging.
@yunaseoul yunaseoul requested a review from a team as a code owner March 12, 2026 18:49
@gemini-cli
Copy link
Copy Markdown
Contributor

gemini-cli bot commented Mar 12, 2026

Hi @yunaseoul, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a telemetry schema compliance issue by ensuring that all timing-related metrics within the StartupProfiler (specifically duration_ms, start_time_usec, and end_time_usec) are recorded as integer values. This prevents floating-point numbers from being emitted, which could cause validation failures in downstream telemetry systems, and is validated by new unit tests.

Highlights

  • Telemetry Data Formatting: Ensured that startup stats timestamps (start_time_usec, end_time_usec) and duration (duration_ms) are correctly formatted as rounded integers to comply with telemetry schema requirements.
  • Unit Testing: Added new unit tests to startupProfiler.test.ts to explicitly verify that startup stats timestamps and durations are logged as integers.
Changelog
  • packages/core/src/telemetry/startupProfiler.test.ts
    • Added a test to verify that startup stats timestamps (start_time_usec, end_time_usec) are logged as rounded integers.
    • Added a test to verify that startup stats duration (duration_ms) is logged as a rounded integer.
  • packages/core/src/telemetry/startupProfiler.ts
    • Applied Math.round() to measure.duration when assigning to duration_ms.
    • Applied Math.round() to the calculated start_time_usec.
    • Applied Math.round() to the calculated end_time_usec.
Activity
  • Added/updated tests to validate the fix.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@yunaseoul yunaseoul changed the title fix(core): ensure startup stats use integer values for timestamps and durations fix(core): fix startup stats to use int values for timestamps and durations Mar 12, 2026
@github-actions
Copy link
Copy Markdown

Size Change: +96 B (0%)

Total Size: 26.6 MB

ℹ️ View Unchanged
Filename Size Change
./bundle/gemini.js 26.1 MB +96 B (0%)
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB 0 B
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B 0 B
./bundle/sandbox-macos-permissive-open.sb 890 B 0 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB 0 B
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB 0 B
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB 0 B
./bundle/sandbox-macos-strict-open.sb 4.82 kB 0 B
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB 0 B

compressed-size-action

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the StartupProfiler to ensure that timestamp and duration values for startup telemetry are integers, addressing a schema compliance issue. This is achieved by rounding the values using Math.round(). New unit tests have been added to verify that the output values are integers. The changes appear correct and effectively solve the described problem.

Note: Security Review did not run due to the size of the PR.

@yunaseoul yunaseoul enabled auto-merge March 12, 2026 19:02
@yunaseoul yunaseoul added this pull request to the merge queue Mar 12, 2026
@gemini-cli gemini-cli bot added area/platform Issues related to Build infra, Release mgmt, Testing, Eval infra, Capacity, Quota mgmt area/enterprise Issues related to Telemetry, Policy, Quota / Licensing 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item. labels Mar 12, 2026
Merged via the queue into main with commit 391715c Mar 12, 2026
31 checks passed
@yunaseoul yunaseoul deleted the yunaseol/startup-stats branch March 12, 2026 19:17
ruomengz pushed a commit that referenced this pull request Mar 13, 2026
…ations (#22201)

Co-authored-by: Yuna Seol <yunaseol@google.com>
SUNDRAM07 pushed a commit to SUNDRAM07/gemini-cli that referenced this pull request Mar 30, 2026
…ations (google-gemini#22201)

Co-authored-by: Yuna Seol <yunaseol@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/enterprise Issues related to Telemetry, Policy, Quota / Licensing area/platform Issues related to Build infra, Release mgmt, Testing, Eval infra, Capacity, Quota mgmt 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants