fix(core): fix startup stats to use int values for timestamps and durations#22201
fix(core): fix startup stats to use int values for timestamps and durations#22201
Conversation
… durations Round `duration_ms`, `start_time_usec`, and `end_time_usec` to the nearest integer in `StartupProfiler` to ensure schema compliance and consistent telemetry logging.
|
Hi @yunaseoul, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a telemetry schema compliance issue by ensuring that all timing-related metrics within the StartupProfiler (specifically duration_ms, start_time_usec, and end_time_usec) are recorded as integer values. This prevents floating-point numbers from being emitted, which could cause validation failures in downstream telemetry systems, and is validated by new unit tests. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Size Change: +96 B (0%) Total Size: 26.6 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request modifies the StartupProfiler to ensure that timestamp and duration values for startup telemetry are integers, addressing a schema compliance issue. This is achieved by rounding the values using Math.round(). New unit tests have been added to verify that the output values are integers. The changes appear correct and effectively solve the described problem.
Note: Security Review did not run due to the size of the PR.
…ations (#22201) Co-authored-by: Yuna Seol <yunaseol@google.com>
…ations (google-gemini#22201) Co-authored-by: Yuna Seol <yunaseol@google.com>
Summary
Ensures that startup stats timestamps and duration values are correctly formatted as integers in
StartupProfiler.Details
Applied
Math.round()toduration_ms,start_time_usec, andend_time_usecbefore adding them to the telemetry startup phases. This fixes schema compliance issues related to telemetry logging where floating-point numbers were being emitted instead of integers. Added unit tests to verify the integer outputs.Related Issues
Related to #21161
Related to https://github.com/google-gemini/maintainers-gemini-cli/issues/1513
How to Validate
npm test -w @google/gemini-cli-core -- src/telemetry/startupProfiler.test.tsPre-Merge Checklist