Revert "fix(cli): validate --model argument at startup"#22378
Conversation
This reverts commit 34709dc.
|
Hi @sehoon38, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request rolls back a previous change that introduced client-side validation for the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request reverts the startup validation for the --model argument. The removal of the validation logic in config.ts and the corresponding cleanup in models.ts and test files are consistent with the revert.
However, I've noticed a change in config.test.ts that seems unrelated to the revert and potentially introduces a typo for a model name. My review includes a comment with a suggestion to address this.
|
|
||
| it('always prefers model from argv', async () => { | ||
| process.argv = ['node', 'script.js', '--model', 'gemini-2.5-flash']; | ||
| process.argv = ['node', 'script.js', '--model', 'gemini-2.5-flash-preview']; |
There was a problem hiding this comment.
The model name gemini-2.5-flash-preview appears to be a typo, as it's not a defined model constant in packages/core/src/config/models.ts. This change seems to have been made as part of the revert, but it introduces a potentially invalid model name into the tests. It's better to use a known valid model, like the previous value gemini-2.5-flash which corresponds to the DEFAULT_GEMINI_FLASH_MODEL constant. This improves clarity and ensures tests are using valid data. This applies to the other occurrences of gemini-2.5-flash-preview in this file as well.
| process.argv = ['node', 'script.js', '--model', 'gemini-2.5-flash-preview']; | |
| process.argv = ['node', 'script.js', '--model', 'gemini-2.5-flash']; |
|
Size Change: -356 B (0%) Total Size: 26.1 MB
ℹ️ View Unchanged
|
gemini-cli
bot
added
the
status/need-issue
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
2 participants
Reverts #21393