Fix issue where subagent thoughts are appended.#22975
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue in the subagent invocation mechanism where successive thought activities were concatenated rather than updated. The change ensures that the agent's current thought is accurately reflected by replacing previous thought fragments with new ones, leading to a clearer and more precise representation of the subagent's internal processing. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Size Change: -5 B (0%) Total Size: 26.2 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
The pull request updates the LocalSubagentInvocation to modify how THOUGHT_CHUNK activities are processed. Instead of appending new thought chunk text to the existing content of a running thought, the change ensures that new thought chunk data now replaces the content of the last running thought. This behavior is reflected in updated test cases that assert the replacement of thought content rather than its accumulation.
Fixes an issue where subagent thoughts were appended together instead of replaced.