Skip to content

Fix issue where subagent thoughts are appended.#22975

Merged
gundermanc merged 1 commit intomainfrom
gundermanc/fix-append
Mar 18, 2026
Merged

Fix issue where subagent thoughts are appended.#22975
gundermanc merged 1 commit intomainfrom
gundermanc/fix-append

Conversation

@gundermanc
Copy link
Copy Markdown
Member

Fixes an issue where subagent thoughts were appended together instead of replaced.

@gundermanc gundermanc requested a review from a team as a code owner March 18, 2026 17:59
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in the subagent invocation mechanism where successive thought activities were concatenated rather than updated. The change ensures that the agent's current thought is accurately reflected by replacing previous thought fragments with new ones, leading to a clearer and more precise representation of the subagent's internal processing.

Highlights

  • Subagent Thought Display: Fixed a bug where subagent thoughts were incorrectly appended to previous thoughts. Now, new thought chunks replace the existing running thought, ensuring only the most current thought is displayed.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions
Copy link
Copy Markdown

Size Change: -5 B (0%)

Total Size: 26.2 MB

Filename Size Change
./bundle/chunk-C2X6PXAW.js 0 B -3.63 MB (removed) 🏆
./bundle/chunk-I3RP3WGB.js 0 B -13.5 MB (removed) 🏆
./bundle/core-DDAQZT5C.js 0 B -41.4 kB (removed) 🏆
./bundle/devtoolsService-URNB3QAR.js 0 B -27.7 kB (removed) 🏆
./bundle/interactiveCli-EI7ZI4BK.js 0 B -1.61 MB (removed) 🏆
./bundle/oauth2-provider-TK26MLAL.js 0 B -9.19 kB (removed) 🏆
./bundle/chunk-3GTTKUFV.js 3.63 MB +3.63 MB (new file) 🆕
./bundle/chunk-GVE2OMKJ.js 13.5 MB +13.5 MB (new file) 🆕
./bundle/core-5FPP4RLB.js 41.4 kB +41.4 kB (new file) 🆕
./bundle/devtoolsService-VZNB5KE5.js 27.7 kB +27.7 kB (new file) 🆕
./bundle/interactiveCli-QAUA5CD5.js 1.61 MB +1.61 MB (new file) 🆕
./bundle/oauth2-provider-TZVXV3DC.js 9.19 kB +9.19 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
./bundle/chunk-34MYV7JD.js 2.45 kB
./bundle/chunk-37ZTTFQF.js 966 kB
./bundle/chunk-5AUYMPVF.js 858 B
./bundle/chunk-664ZODQF.js 124 kB
./bundle/chunk-DAHVX5MI.js 206 kB
./bundle/chunk-G4TMH6EN.js 1.95 MB
./bundle/chunk-IUUIT4SU.js 56.5 kB
./bundle/chunk-RJTRUG2J.js 39.8 kB
./bundle/devtools-36NN55EP.js 696 kB
./bundle/dist-T73EYRDX.js 356 B
./bundle/gemini.js 696 kB
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB
./bundle/memoryDiscovery-KKSSU3SI.js 922 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB
./bundle/sandbox-macos-strict-open.sb 4.82 kB
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB
./bundle/src-QVCVGIUX.js 47 kB
./bundle/tree-sitter-7U6MW5PS.js 274 kB
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB
./bundle/undici-4X2YZID5.js 360 B

compressed-size-action

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the LocalSubagentInvocation to modify how THOUGHT_CHUNK activities are processed. Instead of appending new thought chunk text to the existing content of a running thought, the change ensures that new thought chunk data now replaces the content of the last running thought. This behavior is reflected in updated test cases that assert the replacement of thought content rather than its accumulation.

@gemini-cli gemini-cli bot added the status/need-issue Pull requests that need to have an associated issue. label Mar 18, 2026
@gundermanc gundermanc added this pull request to the merge queue Mar 18, 2026
Merged via the queue into main with commit 0082e1e Mar 18, 2026
30 checks passed
@gundermanc gundermanc deleted the gundermanc/fix-append branch March 18, 2026 19:37
ProthamD pushed a commit to ProthamD/gemini-cli that referenced this pull request Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/need-issue Pull requests that need to have an associated issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants