fix(plan): clarify that plan mode policies are combined with normal mode#23158
fix(plan): clarify that plan mode policies are combined with normal mode#23158
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the clarity of the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the output of the policies command to clarify that Plan Mode policies are combined with Normal Mode policies, making the header consistent with other modes. The change modifies a string in policiesCommand.ts and updates the corresponding unit tests. The implementation correctly reflects the underlying policy logic where plan mode inherits normal mode rules. The changes are accurate and I have no further comments.
|
Size Change: +51 B (0%) Total Size: 26.3 MB
ℹ️ View Unchanged
|
Summary
Clarifies in the
policiescommand output that Plan Mode policies are combined with Normal Mode policies.Details
Updated the
listPoliciesCommandinpackages/cli/src/ui/commands/policiesCommand.tsto use the more descriptive section header: "Plan Mode Policies (combined with normal mode policies)". Updated corresponding unit tests to reflect this change.Related Issues
Fixes #22434
How to Validate
/policiescommand in the CLI.npm test -w @google/gemini-cli -- src/ui/commands/policiesCommand.test.tsPre-Merge Checklist