Skip to content

fix(plan): clarify that plan mode policies are combined with normal mode#23158

Merged
ruomengz merged 1 commit intomainfrom
fix/22434-policies-list-plan
Mar 19, 2026
Merged

fix(plan): clarify that plan mode policies are combined with normal mode#23158
ruomengz merged 1 commit intomainfrom
fix/22434-policies-list-plan

Conversation

@ruomengz
Copy link
Copy Markdown
Contributor

@ruomengz ruomengz commented Mar 19, 2026

Summary

Clarifies in the policies command output that Plan Mode policies are combined with Normal Mode policies.

Details

Updated the listPoliciesCommand in packages/cli/src/ui/commands/policiesCommand.ts to use the more descriptive section header: "Plan Mode Policies (combined with normal mode policies)". Updated corresponding unit tests to reflect this change.

Related Issues

Fixes #22434

How to Validate

  1. Run the /policies command in the CLI.
  2. Observe the output section for Plan Mode policies.
  3. Verify it contains the clarified parenthetical note.
  4. Run unit tests: npm test -w @google/gemini-cli -- src/ui/commands/policiesCommand.test.ts

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)
  • Validated on required platforms/methods:
    • MacOS
      • npm run

@ruomengz ruomengz requested a review from a team as a code owner March 19, 2026 21:06
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the clarity of the policies command output in the CLI. It specifically modifies the display of "Plan Mode Policies" to explicitly indicate that they are combined with "Normal Mode Policies," addressing a potential point of confusion for users regarding policy application.

Highlights

  • CLI Output Clarity: The policies command output now explicitly states that "Plan Mode Policies" are combined with "Normal Mode Policies" for better user understanding.
  • Code Implementation: The listPoliciesCommand in policiesCommand.ts was updated to use the more descriptive section header.
  • Testing: Corresponding unit tests in policiesCommand.test.ts were updated to reflect the new expected output string.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ruomengz ruomengz changed the title fix(cli): clarify that plan mode policies are combined with normal mode fix(plan): clarify that plan mode policies are combined with normal mode Mar 19, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the output of the policies command to clarify that Plan Mode policies are combined with Normal Mode policies, making the header consistent with other modes. The change modifies a string in policiesCommand.ts and updates the corresponding unit tests. The implementation correctly reflects the underlying policy logic where plan mode inherits normal mode rules. The changes are accurate and I have no further comments.

@github-actions
Copy link
Copy Markdown

Size Change: +51 B (0%)

Total Size: 26.3 MB

Filename Size Change
./bundle/chunk-2JUPI7QT.js 0 B -3.63 MB (removed) 🏆
./bundle/chunk-KZ6CX3GN.js 0 B -13.5 MB (removed) 🏆
./bundle/core-TQ4DKVIE.js 0 B -41.6 kB (removed) 🏆
./bundle/devtoolsService-DVLLPVOJ.js 0 B -27.7 kB (removed) 🏆
./bundle/interactiveCli-2TKP3LZM.js 0 B -1.61 MB (removed) 🏆
./bundle/oauth2-provider-LLLJ32ZQ.js 0 B -9.19 kB (removed) 🏆
./bundle/chunk-4XTQW6BC.js 13.5 MB +13.5 MB (new file) 🆕
./bundle/chunk-SN3MMVI6.js 3.63 MB +3.63 MB (new file) 🆕
./bundle/core-ICAHHWO4.js 41.6 kB +41.6 kB (new file) 🆕
./bundle/devtoolsService-4RHPY6QE.js 27.7 kB +27.7 kB (new file) 🆕
./bundle/interactiveCli-KPXVKRFH.js 1.61 MB +1.61 MB (new file) 🆕
./bundle/oauth2-provider-2RADIPCF.js 9.19 kB +9.19 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
./bundle/chunk-34MYV7JD.js 2.45 kB
./bundle/chunk-37ZTTFQF.js 966 kB
./bundle/chunk-5AUYMPVF.js 858 B
./bundle/chunk-664ZODQF.js 124 kB
./bundle/chunk-DAHVX5MI.js 206 kB
./bundle/chunk-IUUIT4SU.js 56.5 kB
./bundle/chunk-RJTRUG2J.js 39.8 kB
./bundle/chunk-TCYGHW2X.js 1.95 MB
./bundle/devtools-36NN55EP.js 696 kB
./bundle/dist-T73EYRDX.js 356 B
./bundle/gemini.js 697 kB
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB
./bundle/memoryDiscovery-C47CWCMG.js 922 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 221 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 227 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 11.5 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB
./bundle/sandbox-macos-strict-open.sb 4.82 kB
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB
./bundle/src-QVCVGIUX.js 47 kB
./bundle/tree-sitter-7U6MW5PS.js 274 kB
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB
./bundle/undici-4X2YZID5.js 360 B

compressed-size-action

@gemini-cli gemini-cli bot added area/agent Issues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Quality 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item. labels Mar 19, 2026
@ruomengz ruomengz added this pull request to the merge queue Mar 19, 2026
Merged via the queue into main with commit 98d1bec Mar 19, 2026
50 of 52 checks passed
@ruomengz ruomengz deleted the fix/22434-policies-list-plan branch March 19, 2026 22:05
ProthamD pushed a commit to ProthamD/gemini-cli that referenced this pull request Mar 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/agent Issues related to Core Agent, Tools, Memory, Sub-Agents, Hooks, Agent Quality 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix execution allowed in plan mode

2 participants