Changes to add tool_type as dimension

[agarwalravikant]

TLDR

Adds tool_type as a dimension to enhance logging mechanism.

Testing Matrix

	🍏	🪟	🐧
npm run	❓	❓	❓
npx	❓	❓	❓
Docker	❓	❓	❓
Podman	❓	-	-
Seatbelt	❓	-	-

Linked issues / bugs

• Closes Add tool_type as a dimension to tool_call metric and clearcut logging. #6533

[gemini-code-assist]

Summary of Changes

Hello @agarwalravikant, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the logging and telemetry mechanism by introducing a new tool_type dimension. This dimension differentiates between 'mcp' (Managed Cloud Platform) and 'native' tool calls, providing more granular insights into tool usage and performance within the system.

Highlights

• Enhanced Telemetry Data: A new tool_type attribute has been added to the gemini_cli.tool.call.latency metric, allowing for better categorization of tool call events as either 'mcp' or 'native'.
• Dynamic Tool Type Identification: Logic has been implemented across core modules (zedIntegration.ts, nonInteractiveToolExecutor.ts, types.ts) to dynamically determine and assign the tool_type based on whether a tool is an instance of DiscoveredMCPTool.
• Comprehensive Logging Integration: The tool_type dimension is now consistently captured and logged across various tool call scenarios, including successful calls, errors, and unhandled exceptions.
• Documentation and Test Alignment: The official telemetry documentation (docs/telemetry.md) has been updated to reflect the new tool_type attribute, and corresponding unit tests (loggers.test.ts) have been adjusted to validate its correct logging.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds a tool_type dimension to the telemetry for tool calls, which is a valuable enhancement for logging. The implementation is mostly correct, but I've identified a critical issue in packages/cli/src/zed-integration/zedIntegration.ts that could lead to a runtime ReferenceError. My review includes a specific code suggestion to fix this bug.