Inline fn get_fn_sig into its callers.#701
Merged
copybara-service[bot] merged 1 commit intomainfrom Mar 18, 2026
Merged
Conversation
copybara-service
bot
force-pushed
the
test_884700042
branch
2 times, most recently
from
6e48e7f to
cb842c8
Compare
copybara-service
bot
changed the title
fn get_fn_sig.fn get_fn_sig into its callers.
Not all generic functions can be supported (currently none are supported) so this means that `fn get_fn_sig` would need to return a fallible `Result`. But 2 out of 3 callers don't really care about generics, so inlining seems to result in a bit simpler code. PiperOrigin-RevId: 885800534
copybara-service
bot
force-pushed
the
test_884700042
branch
from
cb842c8 to
96c6797
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline
fn get_fn_siginto its callers.Not all generic functions can be supported (currently none are
supported) so this means that
fn get_fn_sigwould need to return afallible
Result. But 2 out of 3 callers don't really care aboutgenerics, so inlining seems to result in a bit simpler code.