Generate bindings to trait implementations of C++ types.#704
Open
copybara-service[bot] wants to merge 1 commit intomainfrom
Open
Generate bindings to trait implementations of C++ types.#704copybara-service[bot] wants to merge 1 commit intomainfrom
copybara-service[bot] wants to merge 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
test_885623459
branch
2 times, most recently
from
fbbc8bf to
d4a54a7
Compare
copybara-service
bot
changed the title
Previously, we needlessly excluded these implementations that referenced a type with a `cpp_type` annotation due to the `adt_needs_bindings` check. This adds a specific carve out for that when considering implementations. PiperOrigin-RevId: 885623459
copybara-service
bot
force-pushed
the
test_885623459
branch
from
d4a54a7 to
719f9ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate bindings to trait implementations of C++ types.
Previously, we needlessly excluded these implementations that referenced
a type with a
cpp_typeannotation due to theadt_needs_bindingscheck. This adds a specific carve out for that when considering
implementations.