-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Use libunwind as an imported target #368
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
sergiud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please sign the CLA first.
Second, please avoid code duplication. The code should be put into a find module which is installed along glog under <prefix>/share/glog/cmake. The package config would then use find_dependency to correctly locate libunwind.
|
CLAs look good, thanks! |
|
@sergiud Thanks for the review. Could you please take a look if it looks better now? |
|
I figured there's still room for improvement here. For example, libunwind is not found in cross-compilation environment. Please hold off for a while |
|
Updated. Please take a look again |
e7e5d51 to
98ec970
Compare
|
@sergiud I was wondering if you have any other comments/suggestions on this.. |
0bfb0d4 to
2583eb2
Compare
2ddd2bb to
bfdc70a
Compare
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
When UNWIND_LIBRARY is used directly as a public dependency then absolute path is stored in cmake config file. This is an issue when glog is used as part of an SDK, which was built somewhere else. When SDK is installed on developer's machine, cmake config contains a full path to non-existent location. The solution is to find libunwind during configure stage and store target name as a dependency, not a full path. Cmake module looks for libunwind and libunwind-PLAT, where PLAT is one of supported platforms. Signed-off-by: Vyacheslav Yurkov <[email protected]>
683547e to
7df323d
Compare
1ad7317 to
41d80a9
Compare
41d80a9 to
c0463b1
Compare
When UNWIND_LIBRARY is used directly as a public dependency then
absolute path is stored in cmake config file. This is an issue when
glog is used as part of an SDK, which was built somewhere else. When
SDK is installed on developer's machine, cmake config contains a full
path to non-existent location. The solution is to find libunwind
during configure stage and store target name as a dependency, not a full path