This repository was archived by the owner on Jun 30, 2025. It is now read-only.
cmake: Fix incorrect relative-path concatenation #733
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a `-DCMAKE_INSTALL_PREFIX` is given, this could result in paths
like:
/path/to/prefix//path/to/prefix/lib/cmake/glog/glog-modules.cmake
which was incorrect.
If a relative DESTINATION is given, it's assumed to be relative to the
install prefix.
Signed-off-by: Niklas Hambüchen <[email protected]>
11 tasks
Collaborator
Collaborator
Contributor
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect install location of
glog-modules.cmakefound in NixOS/nixpkgs#144561 (comment)Please see the commit message for details.
CLA is signed.