This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #752 +/- ##
==========================================
+ Coverage 71.38% 72.65% +1.27%
==========================================
Files 17 17
Lines 3208 3211 +3
==========================================
+ Hits 2290 2333 +43
+ Misses 918 878 -40
Continue to review full report at Codecov.
|
Member
|
I've set the repository secret. However, I also lack access to that page. If the problem persists, let me know and I can try to seek out a suitable admin. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@drigz It looks like we do need to set the upload token (
CODECOV_TOKEN) because coverage uploads sometimes fail despite previously successful builds:[2021-12-06T20:25:06.918Z] ['verbose'] The error stack is: Error: Error uploading to https://codecov.io: Error: There was an error fetching the storage URL during POST: 404 - Not Found - {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}The token can be added in repository
Settings -> Secrets -> Repository secrets. The token can be obtained from codecov.Codecov settings also mention that "Github Integration is installed. However, this repository is not enabled." Thus, glog needs to be whitelisted by following the link on the page which I don't have access to.