LogCleaner: Fix relative paths and add a new test

[aesophor]

Overview

Currently, if the user sets the log destination using a relative path (e.g., "testdir/"), then the log cleaner will scan "." for logs instead of "testdir/". This PR fixes the problem and adds a new test.

Root Cause

• The second parameter pos of string::find_last_of indicates the position at which the search is to finish.
• We should pass string::npos instead of 0 at line 1333.

glog/src/logging.cc

Lines 1333 to 1341 in 3362cc6

	size_t pos = base_filename.find_last_of(possible_dir_delim, 0,
	sizeof(possible_dir_delim));
	if (pos != string::npos) {
	string dir = base_filename.substr(0, pos + 1);
	dirs.push_back(dir);
	} else {
	dirs.push_back(".");
	}
	}

Fix

• Pass string::npos instead of 0 at line 1333.
• A new test is added (modified from src/cleanup_with_prefix_unittest.cc)
  • In ${TEST_DIR}, create a subdirectory named "test_subdir"
  • After executing the unit test, it expects a single log file in ${TEST_DIR}/test_subdir
  • In ${TEST_DIR}, remove the "test_subdir" directory

[codecov-commenter]

Codecov Report

Merging #754 (b791102) into master (ee6faf1) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #754      +/-   ##
==========================================
+ Coverage   72.65%   72.74%   +0.09%     
==========================================
  Files          17       17              
  Lines        3211     3211              
==========================================
+ Hits         2333     2336       +3     
+ Misses        878      875       -3     

Impacted Files	Coverage Δ
src/logging.cc	73.91% <100.00%> (+0.23%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee6faf1...b791102. Read the comment docs.

[sergiud]

[...] the log cleaner will not behave as intended.

What does this mean exactly, i.e., what is the intended behavior?

[aesophor]

[...] the log cleaner will not behave as intended.

What does this mean exactly, i.e., what is the intended behavior?

I've updated the description of this PR.

if the user sets the log destination using a relative path (e.g., "testdir/"), then the log cleaner will scan "." for logs instead of "testdir/"

[sergiud]

Could you please also rebase onto current master and squash all the commits?

[aesophor]

I've squashed all the commits into one, and renamed cleanup_with_prefix to cleanup_with_absolute_prefix. Thanks!

[sergiud]

Thanks!