This repository was archived by the owner on Jun 30, 2025. It is now read-only.
Tests: Respect TEST_TMPDIR, TMPDIR, TMP environmental variables#794
Merged
sergiud merged 2 commits intogoogle:masterfrom Feb 20, 2022
Arfrever:tests-TMPDIR
Merged
Tests: Respect TEST_TMPDIR, TMPDIR, TMP environmental variables#794sergiud merged 2 commits intogoogle:masterfrom Arfrever:tests-TMPDIR
sergiud merged 2 commits intogoogle:masterfrom
Arfrever:tests-TMPDIR
Conversation
Codecov Report
@@ Coverage Diff @@
## master #794 +/- ##
==========================================
+ Coverage 72.78% 73.02% +0.24%
==========================================
Files 17 17
Lines 3259 3259
==========================================
+ Hits 2372 2380 +8
+ Misses 887 879 -8
Continue to review full report at Codecov.
|
sergiud
suggested changes
Feb 19, 2022
Contributor
sergiud
left a comment
sergiud
left a comment
There was a problem hiding this comment.
Thanks for the PR. Only couple of suggestions.
added 2 commits
February 19, 2022 20:07
Use GetExistingTempDirectories() (which uses GetTempDirectories() which respects TEST_TMPDIR, TMPDIR, TMP environmental variables) for FLAGS_test_tmpdir variable used in some tests. Fixes: #793
sergiud
approved these changes
Feb 20, 2022
Contributor
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use GetExistingTempDirectories() (which uses GetTempDirectories() which respects
TEST_TMPDIR, TMPDIR, TMP environmental variables) for FLAGS_test_tmpdir variable
used in some tests.
Fixes: #793