Skip to content

revert path traversal and symlink escape from #2227#2250

Merged
Subserial merged 1 commit intogoogle:mainfrom
Subserial:unf_ck
Mar 31, 2026
Merged

revert path traversal and symlink escape from #2227#2250
Subserial merged 1 commit intogoogle:mainfrom
Subserial:unf_ck

Conversation

@Subserial
Copy link
Copy Markdown
Contributor

@Subserial Subserial commented Mar 31, 2026

Fixes #2244, #2244

This change has broken functionality for enough users to consider reviewing why #2227 was necessary. This program does not write tar files and links to disk, and the manipulation of the contents runs against the preferred behavior.

@KevinZhao please have more consideration for the changes you prompt for this repository in the future.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.70%. Comparing base (8b3c303) to head (08e1d4c).
⚠️ Report is 98 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (8b3c303) and HEAD (08e1d4c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (8b3c303) HEAD (08e1d4c)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2250       +/-   ##
===========================================
- Coverage   71.67%   52.70%   -18.97%     
===========================================
  Files         123      164       +41     
  Lines        9935    11105     +1170     
===========================================
- Hits         7121     5853     -1268     
- Misses       2115     4546     +2431     
- Partials      699      706        +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Subserial Subserial merged commit 0d0368c into google:main Mar 31, 2026
17 checks passed
@nvsmirnov nvsmirnov mentioned this pull request Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

crane: export drops symlinks

3 participants