[protocol] Add unittest for opentitan get version #170
+75
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esnguyen
force-pushed
the
esnguyen/add_unittest_opentiten_version
branch
3 times, most recently
from
8b4b0a0 to
787ccf4
Compare
ckungler
reviewed
Jan 7, 2026
ckungler
reviewed
Jan 7, 2026
esnguyen
force-pushed
the
esnguyen/add_unittest_opentiten_version
branch
from
787ccf4 to
c177bd1
Compare
With the new feature added for htools to add get version for opentitan. It follows that there should be a unittest that covers the function. Signed-off-by: Ellis Sarza-Nguyen <[email protected]>
esnguyen
force-pushed
the
esnguyen/add_unittest_opentiten_version
branch
from
c177bd1 to
81cee9c
Compare
ckungler
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new feature added for htools to add get version for opentitan. It follows that there should be a unittest that covers the function.