Crash when `setFramesPerCallback(#frames)` is used for input stream

[katyo]

Android Version(s): 9
Android Device(s): several
Oboe Version: latest

Short Description

I develop an app which operates with constantly sized buffer of frames. So I set the number of frames per callback with builder.setFramesPerCallback(256) but the aaudio backend crashes in this case.

Steps To Reproduce

Set the number of frames per callback using builder.setFramesPerCallback(N_of_frames).

Expected behavior

Normal operating.

Actual behavior

SIGABRT with:

F/AudioStreamRecord(26563): maybeConvertDeviceData() conversion size 512 too large for buffer 256
F/libc    (26563): Fatal signal 6 (SIGABRT), code -6 (SI_TKILL) in tid 26636 (AudioRecord), pid 26563
<...>
backtrace:
    #00 pc 0000000000021afc  /system/lib64/libc.so (abort+124)
    #01 pc 00000000000080f8  /system/lib64/liblog.so (__android_log_assert+296)
    #02 pc 0000000000031b94  /system/lib64/libaaudio.so (aaudio::AudioStreamRecord::maybeConvertDeviceData(void const*, int)+236)
    #03 pc 000000000002e30c  /system/lib64/libaaudio.so (aaudio::AudioStreamLegacy::callDataCallbackFrames(unsigned char*, int)+260)
    #04 pc 00000000000371a4  /system/lib64/libaaudio.so (FixedBlockWriter::processVariableBlock(unsigned char*, int)+220)
    #05 pc 000000000002e928  /system/lib64/libaaudio.so (aaudio::AudioStreamLegacy::processCallbackCommon(int, void*)+696)
    #06 pc 000000000005ab04  /system/lib64/libaudioclient.so (android::AudioRecord::processAudioBuffer()+1396)
    #07 pc 000000000005a27c  /system/lib64/libaudioclient.so (android::AudioRecord::AudioRecordThread::threadLoop()+252)
    #08 pc 000000000000fb78  /system/lib64/libutils.so (android::Thread::_threadLoop(void*)+280)
    #09 pc 000000000008429c  /system/lib64/libc.so (__pthread_start(void*)+36)
    #10 pc 00000000000233fc  /system/lib64/libc.so (__start_thread+68)

Additional context

Also I sets channels count to 1 (mono) if it matter.

[philburk]

Thank you! I was able to reproduce this on master using OboeTester on Pixel 3a:

1. launch OboeTester
2. enter "Callback size:" 64
3. tap TEST INPUT
4. uncheck the MMAP box so we use the Legacy path
5. tap OPEN
6. tap START

Internal bug tracker at: 149249791

We should be able to add a workaround by using a BlockSizeAdapter in Oboe.

[rpattabi]

We hit this problem when we tried to start input stream. Any update on this issue? We would appreciate a workaround.

[philburk]

I'll work on this next week.

[rpattabi]

Few high priority issues were identified for this release v1.5. Any idea when this release can be expected? Rough idea about the release will help us plan our work.

[philburk]

09-14 16:48:08.434 9495 9495 F DEBUG : Abort message: 'maybeConvertDeviceData() conversion size 128 too large for buffer 64'
(__android_log_assert+296)
09-14 16:48:08.440 9495 9495 F DEBUG : #2 pc 0000000000031b94 /system/lib64/libaaudio.so (aaudio::AudioStreamRecord::maybeConvertDeviceData(void const*, int)+236)
09-14 16:48:08.440 9495 9495 F DEBUG : #3 pc 000000000002e30c /system/lib64/libaaudio.so (aaudio::AudioStreamLegacy::callDataCallbackFrames(unsigned char*, int)+260)
09-14 16:48:08.440 9495 9495 F DEBUG : #4 pc 00000000000371a4 /system/lib64/libaaudio.so (FixedBlockWriter::processVariableBlock(unsigned char*, int)+220)
09-14 16:48:08.440 9495 9495 F DEBUG : #5 pc 000000000002e928 /system/lib64/libaaudio.so (aaudio::AudioStreamLegacy::processCallbackCommon(int, void*)+696)
09-14 16:48:08.440 9495 9495 F DEBUG : #6 pc 00000000000599ac /system/lib64/libaudioclient.so (android::AudioRecord::processAudioBuffer()+1396)

[philburk]

This is tracked internally in
b/149249791 | AAudio INPUT asserts if AAudioStreamBuilder_setFramesPerDataCallback(small) used
A fix for this is in R AAudio.

[philburk]

@rpattabi - does PR #1011 fix this problem for you?