Fix regressions occuring during PY2 deprecation.#1011
Merged
glados-verma merged 2 commits intogoogle:masterfrom May 27, 2022
dieppedalle:master
Merged
Fix regressions occuring during PY2 deprecation.#1011glados-verma merged 2 commits intogoogle:masterfrom dieppedalle:master
glados-verma merged 2 commits intogoogle:masterfrom
dieppedalle:master
Conversation
glados-verma
previously approved these changes
May 27, 2022
glados-verma
approved these changes
May 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
I fixed a few regressions that occurred because of #1009.
Why I did it
encode()cannot be called on a set of bytes so we check the type before converting to bytes.dummy_threadis removed in PY3.9: https://bugs.python.org/issue37312.This change is