Show failed measurement-less phases as failed#1020
Merged
cricdecyan merged 2 commits intogoogle:masterfrom Sep 16, 2022
Merged
Conversation
Contributor
Author
|
@cricdecyan should I add a commit that includes a rebuilt webfront based on latest master? Or how would you like to proceed here? |
Contributor
|
@lalten I have to upstream some of our internal changes to OpenHTF, after that it will be time to look at this PR. |
Contributor
|
@lalten Please update this PR so I can review it. Thanks. |
By adding `skip`, `error` states and using PhaseRecord.outcome instead of checking measurement.status.
lalten
force-pushed
the
phase-record-outcome
branch
from
5b9f3aa to
da85f9e
Compare
Contributor
Author
|
I rebased to latest master, there were no conflicts |
cricdecyan
approved these changes
Sep 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show failed measurement-less phases as failed in web ui.
By adding
skip,errorstates and using PhaseRecord.outcome instead of checking measurement.status.You will need to rebuild the web app after these changes. That's not included in this PR.
This change is