Revert "Bump eventsource, sockjs-client and webpack-dev-server in /openhtf/output/web_gui"#1059
Merged
glados-verma merged 1 commit intomasterfrom Oct 13, 2022
Conversation
This reverts commit 598651a.
dbhatman
approved these changes
Oct 13, 2022
Collaborator
Author
|
Verified that |
glados-verma
deleted the
revert-1026-dependabot/npm_and_yarn/openhtf/output/web_gui/eventsource-and-sockjs-client-and-webpack-dev-server-2.0.2
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #1026
webpack v3 to v4 is a serious migration, we can't just bump the version number. Right now, running
node run startfor web_gui fails because webpack-cli isn't installed; one cannot be installed without bumping webpack, and webpack cannot be bumped without non-trivial changes to at least the webpack config.Rolling back for now, we'll take a look at this later.
This change is