Fix extra exception when plug init fails.#745
Merged
arsharma1 merged 1 commit intogoogle:masterfrom Mar 28, 2018
Merged
Conversation
Kenadia
suggested changes
Mar 27, 2018
| # Exit early if plug initialization failed. | ||
| self.test_state.finalize_on_failed_plug_initialization( | ||
| phase_executor.ExceptionInfo(*sys.exc_info())) | ||
| return |
Contributor
There was a problem hiding this comment.
Looks good, can we apply the same thing when running the test start?
arsharma1
force-pushed
the
compat23
branch
2 times, most recently
from
2b72ad7 to
bded1a7
Compare
Kenadia
reviewed
Mar 28, 2018
| #if not self.test_record.dut_id: | ||
| # raise BlankDutIdError( | ||
| # 'Blank or missing DUT ID, HTF requires a non-blank ID.') | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
Ah, yes, trying to figure out why unit tests didn't work.
If there is an exception during plug initialization, the test record outcome is never set for the console printing code in _excecute_test_teardown to be called properly. This required a few other changes: * In Phase Executor, don't set the stopping event if there is no current phase running. * In Test State, make sure _finalize always sets the test record outcome. * Add unit tests.
Kenadia
approved these changes
Mar 28, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is an exception during plug initialization, the test record
outcome is never set for the console printing code in
_excecute_test_teardown to be called properly.
This required a few other changes:
current phase running.
outcome.
This change is