Merging units.proto into test_runs.proto to streamline copybara#748
Merged
kdsudac merged 5 commits intogoogle:masterfrom Apr 3, 2018
Merged
Merging units.proto into test_runs.proto to streamline copybara#748kdsudac merged 5 commits intogoogle:masterfrom
kdsudac merged 5 commits intogoogle:masterfrom
Conversation
Contributor
Author
|
Not sure why the travis CI build is failing. Running unit test locally and importing directly from command line locally both work fine. output: |
Contributor
Author
|
Looks like the generated protobuf codes changes with whatever version of the protobuf compiler we're using in travis CI: `` |
Kenadia
approved these changes
Apr 3, 2018
Contributor
Kenadia
left a comment
There was a problem hiding this comment.
Discussed offline. The justification for the change is that the structure of the protos in output/proto/ should match the structure of the protos used by MfgInspector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our copybara sync to internal openhtf removes import of units_pb2 and replaces all references with test_runs_pb2.
Making this switch to streamline and to enable reversible transformations.
This change is