Restructure test state finalization.#749
Merged
arsharma1 merged 1 commit intogoogle:masterfrom Apr 3, 2018
Merged
Conversation
Finalizing the test state causes the loggers to be reset. This also meant that a failure during the teardown phase does not affect the test outcome. Changing this so the finalization always occurs after the teardown phase and plug teardowns to gather their logs.
Kenadia
approved these changes
Apr 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finalizing the test state causes the loggers to be reset. This also
meant that a failure during the teardown phase does not affect the test
outcome.
Changing this so the finalization always occurs after the teardown phase
and plug teardowns to gather their logs.
This change is