Add a --quiet flag that suppresses all CLI output.#763
Merged
Kenadia merged 2 commits intogoogle:masterfrom May 4, 2018
jettisonjoe:quiet_mode
Merged
Add a --quiet flag that suppresses all CLI output.#763Kenadia merged 2 commits intogoogle:masterfrom jettisonjoe:quiet_mode
Kenadia merged 2 commits intogoogle:masterfrom
jettisonjoe:quiet_mode
Conversation
wallacbe
approved these changes
Apr 20, 2018
|
PTAL, thanks |
Kenadia
approved these changes
Apr 27, 2018
| """ | ||
| if CLI_QUIET: | ||
| return | ||
| logger.debug(ANSI_ESC_RE.sub('', msg)) |
Contributor
There was a problem hiding this comment.
The behavior wrt logging seems inconsistent. In most places in this file, we continue to log messages if CLI_QUIET is False. Here, in banner_print, we don't log if CLI_QUIET is False. In bracket_print there is no logging at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is