device_wrapping.DeviceWrappingPlug now supports setting attributes#907
Merged
arsharma1 merged 2 commits intogoogle:masterfrom Jan 14, 2020
dieppedalle:setAttr
Merged
device_wrapping.DeviceWrappingPlug now supports setting attributes#907arsharma1 merged 2 commits intogoogle:masterfrom dieppedalle:setAttr
arsharma1 merged 2 commits intogoogle:masterfrom
dieppedalle:setAttr
Conversation
arsharma1
approved these changes
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Added attribute method of device_wrapping.DeviceWrapping to set the attributes of the device.
Why I did it
In the past it wasn't possible to call setter methods from the underlying driver in the device wrapping plug (only getters were allowed).
This change is