Fixed bug with device_wrapping.DeviceWrappingPlug where the attributes were sometimes not set.#908
Merged
arsharma1 merged 1 commit intogoogle:masterfrom Jan 14, 2020
dieppedalle:master
Merged
Fixed bug with device_wrapping.DeviceWrappingPlug where the attributes were sometimes not set.#908arsharma1 merged 1 commit intogoogle:masterfrom dieppedalle:master
arsharma1 merged 1 commit intogoogle:masterfrom
dieppedalle:master
Conversation
…s were sometimes not set.
arsharma1
approved these changes
Jan 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I did
Setting the attribute of device_wrapping.DeviceWrappingPlug now has two expected behavior:
First:
-If we are setting the _device, then set the attribute from DeviceWrappingPlug (because we are probably calling this setter from the initializer).
-If _device has not been defined then set the attribute in DeviceWrappingPlug.
-If the attribute has already been defined in DeviceWrappingPlug then set that variable.
Otherwise:
-Set the attribute in the _device object.
Why I did it
The device_wrapping.DeviceWrappingPlug didn't set the attributes correctly based on when the super initializer from the children class is being called.
This change is