Merged
Conversation
PiperOrigin-RevId: 294830845
PiperOrigin-RevId: 295795634
PiperOrigin-RevId: 299141301
PiperOrigin-RevId: 300597711
…put callback funcs. PiperOrigin-RevId: 300852825
PiperOrigin-RevId: 301297425
Add the ability to transform measurement values on setting. Adding a built-in one for `with_precision` to automatically round floats. PiperOrigin-RevId: 301469616
The attrs library will be used to replace mutablerecords as part of introducing type annotations. PiperOrigin-RevId: 302761997
Restructure the phase context to remove the hidden context in PhaseState. Instead, just have the running_phase_context call a finalize function in PhaseState to handle all the work. In addition, add the TestState to the PhaseState and remove optional variables. Lastly, include general readability improvements. PiperOrigin-RevId: 302824781
The conf_test wants to run argparse against the command line, but we can use alternate arguments to not modify the real command line. PiperOrigin-RevId: 302929683
Log exceptions tracebacks for exceptions that occur in the TestExecutor thread to expose the underlying issues to the user. These can include plug issues that are not otherwise surfaced. PiperOrigin-RevId: 304090542
Improve the error logging when tests and phases fail to aid debugging. Adding a test_state variable to the test case that was just used during yields_phases to increase testability. Added a unit test that fails if one attempts to use yields_phases/patch_plugs without inheriting from openhtf.util.test.TestCase. Lastly, fixed lint issues. PiperOrigin-RevId: 304514879
Add higher level signals that can process multiple measurements and phases to deliver actionable feedback for the manufacturing pipeline. PiperOrigin-RevId: 305086087
PiperOrigin-RevId: 305344262
The abort logic fails the thread abort exception occurs while the phase thread is still starting the abort thread. Adding an additional event to wait until ready to trigger the abort. PiperOrigin-RevId: 305944255
Add validators that are only used when a Diagnosis Result has been issued for the test. Fix measurements.py lint issues. Add a test state modification callback to openhtf.util.test.TestCase so tests can add test state or diagnoses prior to yielding phases. PiperOrigin-RevId: 306357852
Add DiagnosesStore as the second parameter to the run functions for TestDiagnoser. PiperOrigin-RevId: 306363506
PiperOrigin-RevId: 306964803
PiperOrigin-RevId: 307078009
PiperOrigin-RevId: 307487021
This allows output callbacks to directly use this information. PiperOrigin-RevId: 307724752
Add an `always_fail` field to diagnosers that cause the diagnoses created by the diagnoser to always have their `is_failure` field set to True. PiperOrigin-RevId: 313693148
PiperOrigin-RevId: 314197584
Default the the diagnosis descriptions to empty strings to leave setting them up to developers. Fixed the order of attr.ib calls so that types are first, then defaults, to add clarity. PiperOrigin-RevId: 316144472
cricdecyan
approved these changes
Jun 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Synchronize the diagnoses library.
This change is