Skip to content

update to lighthouse 10.1.1#395

Open
connorjclark wants to merge 9 commits intogoogleads:mainfrom
connorjclark:update-lh-10.1
Open

update to lighthouse 10.1.1#395
connorjclark wants to merge 9 commits intogoogleads:mainfrom
connorjclark:update-lh-10.1

Conversation

@connorjclark
Copy link
Collaborator

Smokes seem to be failing on main already, FYI.

@jburger424
Copy link
Contributor

Sorry for missing this earlier. Looks like there are some new failures though?

@connorjclark
Copy link
Collaborator Author

connorjclark commented May 4, 2023

Yeah, I spent the last hour updating everything. Removed the fake-types and using the real types we started publishing, which uncovered a lot of issues I believe I've fixed now.

I'm unsure about this runWarning I get in the smokes though. "The GPT tag was not requested." on every run ... is isImplTag still up-to-date in terms of the URL assets it checks?

@brendankenny
Copy link
Collaborator

@connorjclark is it also possible to update the ProcessedNavigation.request() calls to pass in the trace directly so we can update that in LH too?

https://github.com/GoogleChrome/lighthouse/blob/b36b21334b835acc7a991852614e08964cb1c063/core/computed/processed-navigation.js#L26

(we probably should have left the types stricter like PageDependencyGraph did so it would have been an error when you switched to the real types)

@connorjclark
Copy link
Collaborator Author

I went back to to 1.5.0 of this plugin (which uses LH 8) and that also results in The GPT tag was not requested.. I don't see any requests matching what lighthouse-plugin-publisher-ads/utils/resource-classification.js is checking for. @jburger424 have the GPT scripts changed recently?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants